Make sure we install FrameworkExtra bundle and not just doctrine/annotations #14387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this. We usually avoid using Flex aliases because it's confusing for some people and doesn't work when not using Flex ... but I think we can make an exception here. |
javiereguiluz
force-pushed
the
annotations
branch
from
78967fe to
fa569bd
Compare
|
Merged in 4.4 and up. Thanks Tobias! |
I am not sure I understand the reasoning here. We do not use the annotations provided by SensioFrameworkExtraBundle, but the |
This was referenced Oct 13, 2020
wouterj
added a commit
that referenced
this pull request
Oct 14, 2020
…. (Nyholm) This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead. Discussion ---------- You need doctrine/annotations for route annotation support. For Symfony 4.4 This will correct the mistake in #14387 There is an alternative to this PR here: #14400 Commits ------- 6a74ba6 You need doctrine/annotations for route annotation support.
wouterj
added a commit
that referenced
this pull request
Oct 14, 2020
This PR was squashed before being merged into the 5.x branch. Discussion ---------- [Routing] Better use of composer require For Symfony 4.4 This will correct the mistake in #14387 If we still want to use the alias, please consider this PR: #14399 Commits ------- 41b7983 [Routing] Better use of composer require
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix #14203 and revert #14198
@javiereguiluz wrote:
This is true. The pack was removed. Currently there is a flex alias to install SensioFrameworkExtraBundle when one run
composer require annotations. That will make sure to install SensioFrameworkExtraBundle and doctrine/annotations.One will always need SensioFrameworkExtraBundle to be able to use route config with annotations, only doctrine/annotations is not good enough.
People that is not using Flex will see the
Could not find package annotationsas @albuquerque53 saw.